FishEye: history findbugs/trunk/findbugs/src/java/edu/umd/cs/findbugs/detect/DumbMethods.java

9581 annotated / raw | Diffs: previous, other | Lines: 888 ( +47, -8 )

Created: 2008-05-11 04:50:08 -0500 (2 months 28 days ago) | Author: bill.pugh | Changeset: 9581

lower priority of Math.abs(32-bit value) when followed by mod of power of 2.
In this case, the Integer.MIN_VALUE will always result in 0.

9577 annotated / raw | Diffs: previous, other | Lines: 849 ( +87, -92 )

Created: 2008-05-10 17:18:54 -0500 (2 months 28 days ago) | Author: bill.pugh | Changeset: 9577

more reduction of instance hash collisions

9231 annotated / raw | Diffs: previous, other | Lines: 854 ( +1, -1 )

Created: 2008-01-10 10:26:15 -0600 (6 months ago) | Author: bill.pugh | Changeset: 9231

fix for [ 1868666 ] check-for-oddness reported, but array length can never be negative

Branch point for: 1.3.2 1.3.3 1.3.4

8990 annotated / raw | Diffs: previous, other | Lines: 854 ( +0, -3 )

Created: 2007-10-16 12:51:22 -0500 (9 months ago) | Author: bill.pugh | Changeset: 8990

Copied (2 times):

import cleanup

Branch point for: 1.3.0 1.3.1

8574 annotated / raw | Diffs: previous, other | Lines: 857 ( +4, -7 )

Created: 2007-08-04 23:35:38 -0500 (12 months ago) | Author: bill.pugh | Changeset: 8574

uniform use of OpcodeStackDetector

8284 annotated / raw | Diffs: previous, other | Lines: 860 ( +1, -1 )

Created: 2007-06-12 12:19:16 -0500 (13 months ago) | Author: bill.pugh | Changeset: 8284

In opcode stack, longs and doubles only consume one slot

7952 annotated / raw | Diffs: previous, other | Lines: 860 ( +35, -35 )

Created: 2007-04-23 20:00:29 -0500 (15 months ago) | Author: bill.pugh | Changeset: 7952

fix indentation

Branch point for: 1.2.0 1.2.1 cc-refactoring

7948 annotated / raw | Diffs: previous, other | Lines: 860 ( +200, -200 )

Created: 2007-04-23 16:10:50 -0500 (15 months ago) | Author: bill.pugh | Changeset: 7948

fix indentation

7937 annotated / raw | Diffs: previous, other | Lines: 860 ( +9, -7 )

Created: 2007-04-23 11:21:08 -0500 (15 months ago) | Author: bill.pugh | Changeset: 7937

Only report DM_BOOLEAN_CTOR if compiled for Java 1.4 or higher

7810 annotated / raw | Diffs: previous, other | Lines: 858 ( +34, -7 )

Created: 2007-03-21 16:59:41 -0500 (16 months ago) | Author: bill.pugh | Changeset: 7810

tune comparison of signed byte with 127.
In particular, b >= 127 is now a low priority

7796 annotated / raw | Diffs: previous, other | Lines: 831 ( +11, -2 )

Created: 2007-03-15 19:22:47 -0500 (16 months ago) | Author: bill.pugh | Changeset: 7796

check for comparison of nonnegative values with negative constants

Tags: 1.2.0-rc3

7751 annotated / raw | Diffs: previous, other | Lines: 822 ( +3, -1 )

Created: 2007-03-09 20:01:43 -0600 (16 months ago) | Author: bill.pugh | Changeset: 7751

fix null pointer exception

7731 annotated / raw | Diffs: previous, other | Lines: 820 ( +13, -1 )

Created: 2007-03-08 19:47:31 -0600 (17 months ago) | Author: bill.pugh | Changeset: 7731

fix [ 1611735 ] use of inefficient Boolean ctor

7728 annotated / raw | Diffs: previous, other | Lines: 808 ( +3, -2 )

Created: 2007-03-08 17:49:35 -0600 (17 months ago) | Author: bill.pugh | Changeset: 7728

provide more/better descriptions of bug annotations

7510 annotated / raw | Diffs: previous, other | Lines: 807 ( +1, -1 )

Created: 2007-02-09 12:07:15 -0600 (17 months ago) | Author: bill.pugh | Changeset: 7510

added DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED

7504 annotated / raw | Diffs: previous, other | Lines: 807 ( +23, -0 )

Created: 2007-02-08 15:50:05 -0600 (17 months ago) | Author: bill.pugh | Changeset: 7504

Added check to not pass a thread where a runnable is expected

7440 annotated / raw | Diffs: previous, other | Lines: 784 ( +1, -1 )

Created: 2007-01-28 19:22:08 -0600 (18 months ago) | Author: bill.pugh | Changeset: 7440

use constructor that allows for per-detector tweaking of priorities

7374 annotated / raw | Diffs: previous, other | Lines: 784 ( +9, -0 )

Created: 2007-01-19 15:48:03 -0600 (18 months ago) | Author: bill.pugh | Changeset: 7374

cleanup
recognize DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT pattern
shorten some msgs for np bugs

7318 annotated / raw | Diffs: previous, other | Lines: 775 ( +12, -1 )

Created: 2007-01-13 15:43:57 -0600 (18 months ago) | Author: bill.pugh | Changeset: 7318

don't report immediate dereference of readLine if ready had been called shortly before

7313 annotated / raw | Diffs: previous, other | Lines: 764 ( +0, -1 )

Created: 2007-01-12 09:54:48 -0600 (18 months ago) | Author: bill.pugh | Changeset: 7313

get rid of debugging code

7312 annotated / raw | Diffs: previous, other | Lines: 765 ( +20, -1 )

Created: 2007-01-11 12:41:58 -0600 (18 months ago) | Author: bill.pugh | Changeset: 7312

add check for Random used only once

7140 annotated / raw | Diffs: previous, other | Lines: 746 ( +5, -1 )

Created: 2006-12-17 07:28:47 -0600 (19 months ago) | Author: bill.pugh | Changeset: 7140

[ 1609941 ] readline() : déréférencement
Handle "o".equals(in.readLine())
http://sourceforge.net/tracker/index.php?func=detail&aid=1609941&group_id=96405&atid=614693

Branch point for: 1.1.3

7025 annotated / raw | Diffs: previous, other | Lines: 742 ( +2, -22 )

Created: 2006-12-03 21:17:31 -0600 (20 months ago) | Author: bill.pugh | Changeset: 7025

findbugs cleanup

6989 annotated / raw | Diffs: previous, other | Lines: 762 ( +2, -2 )

Created: 2006-11-27 16:39:55 -0600 (20 months ago) | Author: bill.pugh | Changeset: 6989

check for URL's being used in a HashMap/HashSet

6987 annotated / raw | Diffs: previous, other | Lines: 762 ( +22, -0 )

Created: 2006-11-27 16:27:34 -0600 (20 months ago) | Author: bill.pugh | Changeset: 6987

Add check for doing a get or contains operation on a Map or Set with a URL

6930 annotated / raw | Diffs: previous, other | Lines: 740 ( +4, -0 )

Created: 2006-11-18 15:44:31 -0600 (20 months ago) | Author: bill.pugh | Changeset: 6930

disable warning about calling gc if the call is in a test method

6802 annotated / raw | Diffs: previous, other | Lines: 736 ( +1, -22 )

Created: 2006-09-26 15:05:28 -0500 (22 months ago) | Author: wpugh | Changeset: 6802

If we see a[x.hashCode()], assume x has a special, dense, nonnegative hashcode

6801 annotated / raw | Diffs: previous, other | Lines: 757 ( +31, -6 )

Created: 2006-09-26 14:02:26 -0500 (22 months ago) | Author: wpugh | Changeset: 6801

fix recognition of which stack entries must be nonnegative

6786 annotated / raw | Diffs: previous, other | Lines: 732 ( +64, -22 )

Created: 2006-09-24 19:38:19 -0500 (22 months ago) | Author: wpugh | Changeset: 6786

add HASHCODE_INT_REMAINDER and RANDOM_INT_REMAINDER as types

6782 annotated / raw | Diffs: previous, other | Lines: 690 ( +8, -4 )

Created: 2006-09-24 09:29:12 -0500 (22 months ago) | Author: wpugh | Changeset: 6782

fix false positive reports for Math.abs(x.hashCode() % n) and Math.abs(r.nextInt() % n)

6544 annotated / raw | Diffs: previous, other | Lines: 686 ( +3, -3 )

Created: 2006-09-05 16:27:32 -0500 (23 months ago) | Author: wpugh | Changeset: 6544

prioritization tweak

6504 annotated / raw | Diffs: previous, other | Lines: 686 ( +2, -2 )

Created: 2006-09-01 06:49:02 -0500 (23 months ago) | Author: wpugh | Changeset: 6504

fix non-short-circuit

6417 annotated / raw | Diffs: previous, other | Lines: 686 ( +16, -3 )

Created: 2006-08-24 20:43:28 -0500 (23 months ago) | Author: wpugh | Changeset: 6417

more priority tweaks

6406 annotated / raw | Diffs: previous, other | Lines: 673 ( +18, -1 )

Created: 2006-08-23 21:24:02 -0500 (23 months ago) | Author: wpugh | Changeset: 6406

new bug patterns: taking the absolute value of a value known to range over all 32 bit values

6361 annotated / raw | Diffs: previous, other | Lines: 656 ( +8, -1 )

Created: 2006-08-16 22:00:08 -0500 (23 months ago) | Author: wpugh | Changeset: 6361

handle invocation of super.equals as a way to handle other classes

6360 annotated / raw | Diffs: previous, other | Lines: 649 ( +1, -0 )

Created: 2006-08-16 20:35:23 -0500 (23 months ago) | Author: wpugh | Changeset: 6360

handle use of try-catch in equals method

6359 annotated / raw | Diffs: previous, other | Lines: 648 ( +2, -1 )

Created: 2006-08-16 19:53:16 -0500 (23 months ago) | Author: wpugh | Changeset: 6359

handle case where .getClass is used rather than instanceof in equals

6358 annotated / raw | Diffs: previous, other | Lines: 647 ( +25, -0 )

Created: 2006-08-16 19:50:21 -0500 (23 months ago) | Author: wpugh | Changeset: 6358

added new detector that looks for equals methods that make assumptions about their arguments

6324 annotated / raw | Diffs: previous, other | Lines: 622 ( +1, -1 )

Created: 2006-08-15 08:26:36 -0500 (23 months ago) | Author: wpugh | Changeset: 6324

priority tweak

6319 annotated / raw | Diffs: previous, other | Lines: 622 ( +47, -2 )

Created: 2006-08-14 19:09:58 -0500 (23 months ago) | Author: wpugh | Changeset: 6319

look for stuff like

byte[] b = ...
if (b[i] == 200) ...

Suprised we didn't already have this

6119 annotated / raw | Diffs: previous, other | Lines: 577 ( +2, -1 )

Created: 2006-07-31 18:13:28 -0500 (2 years ago) | Author: wpugh | Changeset: 6119

priority tweaking for comparison with Integer.MAX_VALUE

6086 annotated / raw | Diffs: previous, other | Lines: 576 ( +1, -1 )

Created: 2006-07-30 07:44:53 -0500 (2 years ago) | Author: wpugh | Changeset: 6086

lower priority for REM_OF_HASHCODE

6061 annotated / raw | Diffs: previous, other | Lines: 576 ( +3, -3 )

Created: 2006-07-27 15:24:15 -0500 (2 years ago) | Author: bassclar | Changeset: 6061

fix bug reported by ruimo: annotations with unknown retention were flagged by DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION detector

5755 annotated / raw | Diffs: previous, other | Lines: 576 ( +5, -0 )

Created: 2006-06-13 06:26:09 -0500 (2 years 1 month ago) | Author: wpugh | Changeset: 5755

new bug pattern: taking rem of a hashCode

5655 annotated / raw | Diffs: previous, other | Lines: 571 ( +1, -1 )

Created: 2006-06-02 09:28:22 -0500 (2 years 2 months ago) | Author: wpugh | Changeset: 5655

comment out debugging code

5653 annotated / raw | Diffs: previous, other | Lines: 571 ( +4, -2 )

Created: 2006-06-02 09:26:48 -0500 (2 years 2 months ago) | Author: wpugh | Changeset: 5653

Fix a couple of bugs in the detection of DM_NEXTINT_VIA_NEXTDOUBLE patterns

5564 annotated / raw | Diffs: previous, other | Lines: 569 ( +19, -7 )

Created: 2006-05-07 15:14:44 -0500 (2 years 3 months ago) | Author: wpugh | Changeset: 5564

Handle case where Integer.MAX_VALUE or Integer.MIN_VALUE is on lhs

5562 annotated / raw | Diffs: previous, other | Lines: 557 ( +18, -0 )

Created: 2006-05-05 16:06:10 -0500 (2 years 3 months ago) | Author: wpugh | Changeset: 5562

add detectors for two Programming puzzlers:
vacuous comparison to Integer.MAX_INTEGER or Integer.MIN_INTEGER
s.replaceAll(".", "/")

5557 annotated / raw | Diffs: previous, other | Lines: 539 ( +2, -3 )

Created: 2006-05-04 16:32:06 -0500 (2 years 3 months ago) | Author: wpugh | Changeset: 5557

Combine bug reports for multiple DM_NEW_FOR_GETCLASS in the same method

5554 annotated / raw | Diffs: previous, other | Lines: 540 ( +12, -5 )

Created: 2006-05-04 15:32:27 -0500 (2 years 3 months ago) | Author: wpugh | Changeset: 5554

merge multiple DM_EXIT reports on same method into single report

5549 annotated / raw | Diffs: previous, other | Lines: 533 ( +21, -0 )

Created: 2006-05-03 22:14:26 -0500 (2 years 3 months ago) | Author: wpugh | Changeset: 5549

Check for using reflection on annotations with source only retention

5497 annotated / raw | Diffs: previous, other | Lines: 512 ( +0, -3 )

Created: 2006-04-08 17:11:55 -0500 (2 years 3 months ago) | Author: dbrosius | Changeset: 5497

remove adapter overridden empty methods

5488 annotated / raw | Diffs: previous, other | Lines: 515 ( +2, -1 )

Created: 2006-04-08 08:27:47 -0500 (2 years 4 months ago) | Author: wpugh | Changeset: 5488

changes to reduce amount of allocation

5469 annotated / raw | Diffs: previous, other | Lines: 514 ( +1, -4 )

Created: 2006-04-05 13:36:33 -0500 (2 years 4 months ago) | Author: wpugh | Changeset: 5469

get rid of all the annoying clone methods

5420 annotated / raw | Diffs: previous, other | Lines: 517 ( +9, -4 )

Created: 2006-03-24 14:27:39 -0600 (2 years 4 months ago) | Author: wpugh | Changeset: 5420

Add @Override annotations (added via Jackpot)

5308 annotated / raw | Diffs: previous, other | Lines: 512 ( +1, -0 )

Created: 2006-01-30 15:01:24 -0600 (2 years 6 months ago) | Author: wpugh | Changeset: 5308

Fix a bug in how we track stack values across a branch.
Start looking at ability to computer dfa over opcode stack

5307 annotated / raw | Diffs: previous, other | Lines: 511 ( +2, -2 )

Created: 2006-01-30 13:19:15 -0600 (2 years 6 months ago) | Author: wpugh | Changeset: 5307

fixes for REM_BY_1

5306 annotated / raw | Diffs: previous, other | Lines: 511 ( +1, -1 )

Created: 2006-01-29 18:05:09 -0600 (2 years 6 months ago) | Author: wpugh | Changeset: 5306

Use right bug pattern name

5230 annotated / raw | Diffs: previous, other | Lines: 511 ( +8, -1 )

Created: 2006-01-16 17:48:24 -0600 (2 years 6 months ago) | Author: wpugh | Changeset: 5230

check for x % 1 == 1 (yes, I got bit by this)

5152 annotated / raw | Diffs: previous, other | Lines: 504 ( +5, -2 )

Created: 2005-12-14 16:04:18 -0600 (2 years 7 months ago) | Author: wpugh | Changeset: 5152

Need to check for delayed gc errors while still in the appropriate method

5095 annotated / raw | Diffs: previous, other | Lines: 501 ( +1, -1 )

Created: 2005-11-18 12:12:24 -0600 (2 years 8 months ago) | Author: daveho | Changeset: 5095

Check stack depth before getting two operands off.

4955 annotated / raw | Diffs: previous, other | Lines: 501 ( +10, -3 )

Created: 2005-08-27 09:00:51 -0500 (2 years 11 months ago) | Author: wpugh | Changeset: 4955

Ignore random % n if immediately passed to Math.abs

4913 annotated / raw | Diffs: previous, other | Lines: 494 ( +0, -1 )

Created: 2005-08-21 21:53:53 -0500 (2 years 11 months ago) | Author: wpugh | Changeset: 4913

import cleanup

4912 annotated / raw | Diffs: previous, other | Lines: 495 ( +1, -1 )

Created: 2005-08-21 21:48:58 -0500 (2 years 11 months ago) | Author: wpugh | Changeset: 4912

get rid of redundant references to Constants2 interface

4883 annotated / raw | Diffs: previous, other | Lines: 495 ( +2, -3 )

Created: 2005-08-18 10:20:59 -0500 (2 years 11 months ago) | Author: wpugh | Changeset: 4883

removed unneeded final modifiers
Use Java 5.0 foreach loops
Various other quickfixes suggested by IntelliJ.

4819 annotated / raw | Diffs: previous, other | Lines: 496 ( +5, -2 )

Created: 2005-08-11 12:40:59 -0500 (2 years 11 months ago) | Author: wpugh | Changeset: 4819

restructure for easier debugging

4792 annotated / raw | Diffs: previous, other | Lines: 493 ( +1, -1 )

Created: 2005-07-30 10:23:41 -0500 (3 years ago) | Author: wpugh | Changeset: 4792

Recent changes made the warnings about integer oring of signed bytes more
accurate, so we can raise the priority level

4787 annotated / raw | Diffs: previous, other | Lines: 493 ( +3, -2 )

Created: 2005-07-28 19:07:52 -0500 (3 years ago) | Author: wpugh | Changeset: 4787

check for for IOR of signed byte more sensitive

4689 annotated / raw | Diffs: previous, other | Lines: 492 ( +3, -2 )

Created: 2005-07-07 18:58:49 -0500 (3 years 1 month ago) | Author: dbrosius | Changeset: 4689

fix problem with BIT_IOR_OF_SIGNED_BYTE where once it is reported, it keeps getting reported for every statement for the rest of the method.

Needed to clear checkForBitIorofSignedByte once reported.

4639 annotated / raw | Diffs: previous, other | Lines: 491 ( +7, -1 )

Created: 2005-06-26 19:51:52 -0500 (3 years 1 month ago) | Author: wpugh | Changeset: 4639

Tweak priorities

4628 annotated / raw | Diffs: previous, other | Lines: 485 ( +12, -9 )

Created: 2005-06-25 11:19:51 -0500 (3 years 1 month ago) | Author: wpugh | Changeset: 4628

refine BIT_IOR_OF_SIGNED_BYTE detector

4622 annotated / raw | Diffs: previous, other | Lines: 482 ( +23, -1 )

Created: 2005-06-25 09:33:28 -0500 (3 years 1 month ago) | Author: wpugh | Changeset: 4622

Add checks for BIT_IOR_OF_SIGNED_BYTE and RV_REM_OF_RANDOM_INT

4285 annotated / raw | Diffs: previous, other | Lines: 460 ( +1, -1 )

Created: 2005-05-23 15:35:32 -0500 (3 years 2 months ago) | Author: daveho | Changeset: 4285

Giant refactoring to move type analysis classes into a subpackage.

4260 annotated / raw | Diffs: previous, other | Lines: 460 ( +4, -3 )

Created: 2005-05-20 22:36:07 -0500 (3 years 2 months ago) | Author: wpugh | Changeset: 4260

shouldn't call next from hasNext even if on different object

4250 annotated / raw | Diffs: previous, other | Lines: 459 ( +15, -15 )

Created: 2005-05-19 16:36:11 -0500 (3 years 2 months ago) | Author: wpugh | Changeset: 4250

Use dfa to check for constant values passed to substring

4152 annotated / raw | Diffs: previous, other | Lines: 459 ( +40, -3 )

Created: 2005-05-10 16:53:13 -0500 (3 years 2 months ago) | Author: wpugh | Changeset: 4152

Add detector for invoking .substring(0) - one of my own mistakes
Add detector for invoking next() from within hasNext() - student code

4078 annotated / raw | Diffs: previous, other | Lines: 422 ( +0, -1 )

Created: 2005-05-01 09:47:28 -0500 (3 years 3 months ago) | Author: wpugh | Changeset: 4078

Fixed up some warnings from within Eclipse
More work on code for deepInstanceOf
Use deepInstanceOf in places where appropriate

4039 annotated / raw | Diffs: previous, other | Lines: 423 ( +1, -1 )

Created: 2005-04-25 20:09:27 -0500 (3 years 3 months ago) | Author: dbrosius | Changeset: 4039

DumbMethods can't be Stateless as gcInvocationBugReport is maintained throughout the lifetime of the analysis run

3999 annotated / raw | Diffs: previous, other | Lines: 423 ( +0, -7 )

Created: 2005-04-19 12:35:55 -0500 (3 years 3 months ago) | Author: daveho | Changeset: 3999

Cleaned up imports. Eliminated some debug print statements.

3998 annotated / raw | Diffs: previous, other | Lines: 430 ( +70, -3 )

Created: 2005-04-19 11:11:21 -0500 (3 years 3 months ago) | Author: daveho | Changeset: 3998

Added a check for monitor wait() method being called on
a j.u.c.Condition.

3919 annotated / raw | Diffs: previous, other | Lines: 363 ( +17, -1 )

Created: 2005-04-13 11:19:44 -0500 (3 years 3 months ago) | Author: wpugh | Changeset: 3919

Enhanced Infinite loop detector (found another one in JDK)
Made UnreadFields detector look for unread static fields
Warn about invoking String methods on result of readLine() (which might be null)
Made NP analysis aware the String methods cannot return null (possibly generating RCN)
Move check for using equals on arrays into Puzzlers
Turned off UseObjectEquals by default

3837 annotated / raw | Diffs: previous, other | Lines: 347 ( +0, -10 )

Created: 2005-03-25 16:13:07 -0600 (3 years 4 months ago) | Author: wpugh | Changeset: 3837

More tweaks for DLS
Working on a new SQL injection detector (currently disabled)

3782 annotated / raw | Diffs: previous, other | Lines: 357 ( +1, -2 )

Created: 2005-03-22 15:02:17 -0600 (3 years 4 months ago) | Author: wpugh | Changeset: 3782

Bill has been a busy boy.

Fixed typos in messages.

Made DLS a style warning.

Fixed some problems with how DLS was being computed.

Added a check for an integer value being cast to a double and then passed
to Math.ceil.

Added toString methods for WarningPropertySets

Rewrote and simplified code to check for result of
integer division being cast to double

Expanded check for SQL injection. This now could catch to much, and we need to
add some data flow analysis to make it smarter.

3768 annotated / raw | Diffs: previous, other | Lines: 358 ( +20, -2 )

Created: 2005-03-17 15:02:16 -0600 (3 years 4 months ago) | Author: wpugh | Changeset: 3768

Check for runFinalizersOnExit
Check for nextDOuble being coerced to int.

3617 annotated / raw | Diffs: previous, other | Lines: 340 ( +25, -3 )

Created: 2005-02-18 14:17:56 -0600 (3 years 5 months ago) | Author: wpugh | Changeset: 3617

More general cases under which invoking System.exit is OK
executeUpdate should be invoked with a constant

3461 annotated / raw | Diffs: previous, other | Lines: 318 ( +7, -2 )

Created: 2005-01-07 23:26:41 -0600 (3 years 6 months ago) | Author: dbrosius | Changeset: 3461

add a marker interface that detectors can 'implement' that informs the method examineClass whether or not the detector is stateless. If it is, the examineClass clones the detector before examining the class, thus keeping the detector and it's newly acquired bloat available for garbage collection.

3261 annotated / raw | Diffs: previous, other | Lines: 313 ( +1, -1 )

Created: 2004-11-30 20:43:26 -0600 (3 years 8 months ago) | Author: dbrosius | Changeset: 3261

allow for larger super constructor sequences

3245 annotated / raw | Diffs: previous, other | Lines: 313 ( +14, -0 )

Created: 2004-11-29 20:13:10 -0600 (3 years 8 months ago) | Author: dbrosius | Changeset: 3245

Add dubious method detector for calling one of the new Thread() constructors without specifying a Runnable object (or deriving from Thread)... Thus causing a noop thread to be created.

3231 annotated / raw | Diffs: previous, other | Lines: 299 ( +31, -0 )

Created: 2004-11-22 13:41:48 -0600 (3 years 8 months ago) | Author: wpugh | Changeset: 3231

Added detector for
(int)(r.nextDouble() * n)

3220 annotated / raw | Diffs: previous, other | Lines: 268 ( +24, -3 )

Created: 2004-11-21 23:26:07 -0600 (3 years 8 months ago) | Author: dbrosius | Changeset: 3220

Add Dubious method detector for pattern

Class c = new XXX().getClass();

just use

Class c = XXX.class;

3125 annotated / raw | Diffs: previous, other | Lines: 247 ( +28, -0 )

Created: 2004-11-06 02:01:54 -0600 (3 years 9 months ago) | Author: dbrosius | Changeset: 3125

Added dumb method detector for
new Integer(1).toString() instead of Integer.toString(1)
as suggested by Avi Drissman in Feature request 1059790

3119 annotated / raw | Diffs: previous, other | Lines: 219 ( +8, -8 )

Created: 2004-11-04 09:37:37 -0600 (3 years 9 months ago) | Author: daveho | Changeset: 3119

Implemented -adjustPriority command line option.

3032 annotated / raw | Diffs: previous, other | Lines: 219 ( +9, -1 )

Created: 2004-10-11 20:54:57 -0500 (3 years 9 months ago) | Author: dbrosius | Changeset: 3032

add experimental DM_CONVERT_CASE for detecting String.toUpperCase and String.toLowerCase calls without using a Locale. Reported at LOW_PRIORITY. If this is too obnoxious, feel free to remove (or i will). Addresses REQUEST 1043788

3031 annotated / raw | Diffs: previous, other | Lines: 211 ( +0, -17 )

Created: 2004-10-11 20:31:18 -0500 (3 years 9 months ago) | Author: dbrosius | Changeset: 3031

remove DM_ARRAY_COMPARE unless/until it can actually work

3023 annotated / raw | Diffs: previous, other | Lines: 228 ( +3, -1 )

Created: 2004-10-09 02:25:01 -0500 (3 years 9 months ago) | Author: dbrosius | Changeset: 3023

Gak! stupid, stupid, stupid of me. array.equals isn't right so comment out. to be removed i guess. bcel's false positive showed the problem.

2906 annotated / raw | Diffs: previous, other | Lines: 226 ( +16, -0 )

Created: 2004-10-02 01:39:10 -0500 (3 years 10 months ago) | Author: dbrosius | Changeset: 2906

Extend Dubious Method detector to look for calling the standard equals method on an array. As this will determine only whether the arrays are the same object, it is most likely a bug, if this is the intended use, user should have used ==. If not, User should use Arrays.equals instead.

2782 annotated / raw | Diffs: previous, other | Lines: 210 ( +5, -2 )

Created: 2004-08-17 12:24:29 -0500 (3 years 11 months ago) | Author: wpugh | Changeset: 2782

check for nanoTime as well as currentTimeMillis

2763 annotated / raw | Diffs: previous, other | Lines: 207 ( +142, -140 )

Created: 2004-08-11 02:04:19 -0500 (3 years 11 months ago) | Author: briangoetz | Changeset: 2763

Massive whitespace checkin; reformat code with IDEA, substitute all spaces with tabs, conform to 4-space Sun coding conventions.

2738 annotated / raw | Diffs: previous, other | Lines: 205 ( +1, -1 )

Created: 2004-08-09 14:20:59 -0500 (3 years 11 months ago) | Author: wpugh | Changeset: 2738

Lower priority of swing methods being called in main

2688 annotated / raw | Diffs: previous, other | Lines: 205 ( +2, -1 )

Created: 2004-08-06 08:39:27 -0500 (4 years ago) | Author: wpugh | Changeset: 2688

Surpress warnings about System.exit in window closing code

2578 annotated / raw | Diffs: previous, other | Lines: 204 ( +19, -0 )

Created: 2004-07-26 13:58:43 -0500 (4 years ago) | Author: wpugh | Changeset: 2578

Look for swing methods that must be invoked in the swing event thread
being invoked from a public static main method.

2515 annotated / raw | Diffs: previous, other | Lines: 185 ( +8, -0 )

Created: 2004-07-19 09:27:55 -0500 (4 years ago) | Author: daveho | Changeset: 2515

Patch from Dave Brosius <dbrosius@users.sourceforge.net> to
report calls to String.toString() as dubious methods.

2392 annotated / raw | Diffs: previous, other | Lines: 177 ( +11, -0 )

Created: 2004-06-23 10:11:41 -0500 (4 years 1 month ago) | Author: wpugh | Changeset: 2392

Don't complain about calls to System.gc in main methods
or in classes who's name contains benchmark

2388 annotated / raw | Diffs: previous, other | Lines: 166 ( +10, -1 )

Created: 2004-06-23 08:10:56 -0500 (4 years 1 month ago) | Author: daveho | Changeset: 2388

Temporarily disabled DM_STRING_EMPTY_EQUALS

2386 annotated / raw | Diffs: previous, other | Lines: 157 ( +1, -1 )

Created: 2004-06-23 07:15:16 -0500 (4 years 1 month ago) | Author: wpugh | Changeset: 2386

Don't complain about s.equals("")

2361 annotated / raw | Diffs: previous, other | Lines: 157 ( +25, -25 )

Created: 2004-06-17 12:44:07 -0500 (4 years 1 month ago) | Author: daveho | Changeset: 2361

Patch from Brian Goetz to add accessors for protected fields in
the visitor classes. The fields are now private, so use of the
accessors is mandatory.

2339

FishEye

jump to detailed chart Line History

View Mode

Show Arbitrary Diff

Watches and RSS

History

latest revision trunk